wayland: be less stupid with color surface creation #15126
Merged
+5
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
Basically we only want to create the color surface if the compositor supports parametric image descriptions and if the vo is dmabuf-wayland. Instead of doing the weird dance of creating it in one spot and destroying it later, just only make the wayland object when we actually want it. It makes the logging less confusing as well.
Dudemanguy
force-pushed
the
wayland-color-logging
branch
from
95b0471
to
6b5a768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically we only want to create the color surface if the compositor supports parametric image descriptions and if the vo is dmabuf-wayland. Instead of doing the weird dance of creating it in one spot and destroying it later, just only make the wayland object when we actually want it. It makes the logging less confusing as well.