remove external swapchain usage from drm_egl #15948
Open
+4
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudemanguy
force-pushed
the
nuke-external-swapchain
branch
from
420ac6e to
3c77246
Compare
|
Download the artifacts for this pull request: |
5370069 introduced this while implementing n-buffering. The changes are all good, but the suspect part is the implementation of wait_fence/new_fence to specifically bypass what is done generically in context.c for all other opengl backends. The commit message says that the reason for this is because "the places we create and wait for the fences needs to be somewhat different for best performance". It's certainly plausible that it may have been true then, but I see no evidence it's true now. Driver code is way different these days under the hood, and the general vo drm code has been rewritten a lot since then. The generic fencing in context.c works fine and shows no difference compared to this custom implementation. Delete it and simplify.
With the previous commits, all usage of this is gone. We can remove it for good.
Dudemanguy
force-pushed
the
nuke-external-swapchain
branch
from
3c77246 to
6756c56
Compare
|
Sorry about swiping two commits before you had a chance to review. Wanted to fix breakage I caused. |
sfan5
approved these changes
Feb 25, 2025
|
Works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kasper93: It turned out to be way simpler than I thought.