Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework versioning based on Git tags, and modernize Docker configuration #620

Merged
merged 5 commits into from
Feb 13, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 13, 2023

Hi there,

by reworking the versioning based on the existing tags within the Git repository, it will be effortless to tell nightly/on-PR/other pre-releases apart from GA releases.

Also, the Docker configuration has been modernized and improved, to also publish images on pull requests. Along the lines, the patch fixes the general CI setup as discovered while working on GH-619.

With kind regards,
Andreas.

Examples

mqttwarn --version
mqttwarn 0.31.0.post9+g60158d4
docker run -it --rm ghcr.io/jpmens/mqttwarn-standard:pr-620 mqttwarn --version
mqttwarn 0.31.0.post10+g17a4b16.d20230213

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #620 (734710c) into main (ae97072) will increase coverage by 1.95%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   36.68%   38.63%   +1.95%     
==========================================
  Files          80       82       +2     
  Lines        3604     3719     +115     
==========================================
+ Hits         1322     1437     +115     
  Misses       2282     2282              
Flag Coverage Δ
unittests 38.63% <100.00%> (+1.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mqttwarn/__init__.py 100.00% <100.00%> (ø)
mqttwarn/util.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amotl amotl force-pushed the amo/modernize-docker branch from 8fb9e60 to 8e6dcbe Compare February 13, 2023 14:14
@amotl amotl force-pushed the amo/modernize-docker branch from 8e6dcbe to 643de58 Compare February 13, 2023 14:16
@amotl amotl changed the title Modernize and improve Docker configuration Modernize and improve Docker configuration and rework versioning based on Git tags Feb 13, 2023
@amotl amotl force-pushed the amo/modernize-docker branch 2 times, most recently from 05b8bd2 to b2f41f2 Compare February 13, 2023 14:53
@amotl amotl changed the title Modernize and improve Docker configuration and rework versioning based on Git tags Rework versioning based on Git tags, and modernize Docker configuration Feb 13, 2023
@amotl amotl force-pushed the amo/modernize-docker branch from b2f41f2 to 5d9944d Compare February 13, 2023 15:01
@amotl amotl requested review from jpmens and sumnerboy12 February 13, 2023 15:09
@amotl amotl marked this pull request as ready for review February 13, 2023 15:09
@amotl amotl force-pushed the amo/modernize-docker branch 2 times, most recently from 52969b3 to 07e168d Compare February 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants