Duplicate fix, plural fix, multiple output files #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iple output .po files.
…msgstr or comments.
|
@mrblueblue this PR has been open for quite some time, any chance of merging and publishing this PR? |
lucbelliveau
changed the title
|
Hi lucbelliveau, thanks for your PR! This project has fallen off the radar for me, so I apologize for the long response time. I will take a look at this over the weekend! Thanks again for your patience. |
lucbelliveau
added a commit
to lucbelliveau/gettext-loader
that referenced
this pull request
Jul 19, 2018
Merge pull request mrblueblue#16 from lucbelliveau/master
lucbelliveau
added a commit
to lucbelliveau/gettext-loader
that referenced
this pull request
Jul 19, 2018
lucbelliveau
added a commit
to lucbelliveau/gettext-loader
that referenced
this pull request
Jul 19, 2018
Revert "Merge pull request mrblueblue#16 from lucbelliveau/master"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #17
It also addresses #14 a little, but not completely... I added the msgid_plural tag, because python's Babel won't include the plural forms in the .po files without it.
This PR also adds a [filename] variable to the output config directive, if used 1 .po file per javascript file will be created, matching the same path structure to avoid conflicts. I use this to separate the text from each module into its own domain.