-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique error codes #52
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 58 +1
Lines 3411 3441 +30
=========================================
+ Hits 3411 3441 +30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good - some trivial typos (which I'll apply and merge)
This PR adds odin-like error codes, following quite closely the implementation in odin2 (see mrc-ide/odin2#5 for details). There's some harmonisation to do between these later, but I wanted to get this started before it was too big a job later. Many reasonable models still don't parse of course...