Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a port for communication #15

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Use a port for communication #15

wants to merge 14 commits into from

Commits on Oct 10, 2013

  1. First cut at refactoring to make the code easier to use in other exte… 

    …nsions.
    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    0b455ef View commit details
    Browse the repository at this point in the history

  2. README cleanups

    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    e7d0696 View commit details
    Browse the repository at this point in the history

  3. Removed stray console.log line.

    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    59fef18 View commit details
    Browse the repository at this point in the history

  4. Removed inadvertent creation of global 'canvas' var.

    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    35bef40 View commit details
    Browse the repository at this point in the history

  5. Use a port to communicate between the extension and the injected JS. … 

    …This makes sure that no other extension communication can interfere with the screen capture.
    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    d5703dd View commit details
    Browse the repository at this point in the history

  6. Factor out 2 copies of code calling for a next arrangement.

    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    8b77534 View commit details
    Browse the repository at this point in the history

  7. Added a var giving the name of the injected capture script. Changed R… 

    …EADME to tell people they need to change that variable if they rename page.js
    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    58c771b View commit details
    Browse the repository at this point in the history

  8. Corrected behavior (completely ignore) for unknown chrome.runtime.con… 

    …nect connections.
    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    feb2a5b View commit details
    Browse the repository at this point in the history

  9. Increase timeout on waiting for the injected script to be loaded (I j… 

    …ust had it take >1 second). Add 100ms delay before disconnecting the port to avoid occasional exception being thrown due to last message ('done') being in flight.
    @terrycojones
    terrycojones committed Oct 10, 2013
    Configuration menu
    Copy the full SHA
    6c67b26 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2013

  1. Allow more time for the extension to request the next arrangement. 75… 

    …0ms was definitely too short. Test the value of 'port' before using it after a setTimeout.
    @terrycojones
    terrycojones committed Oct 11, 2013
    Configuration menu
    Copy the full SHA
    f282324 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2013

  1. Increased round-trip timeout in page.js to 3s to be conservative.

    @terrycojones
    terrycojones committed Oct 14, 2013
    Configuration menu
    Copy the full SHA
    47756ad View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2013

  1. Up the injection timeout to 3s. May as well be conservative here too.

    @terrycojones
    terrycojones committed Oct 15, 2013
    Configuration menu
    Copy the full SHA
    327c7e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2013

  1. Split out listen code to make sure we only do it once. Added captureT… 

    …oCanvas.
    @terrycojones
    terrycojones committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    8abb049 View commit details
    Browse the repository at this point in the history

  2. Scale the canvas context to account for device pixel ratios that are … 

    …not 1 (the value on a MacBook Pro with Retina display is 2).
    @terrycojones
    terrycojones committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    a0c28a7 View commit details
    Browse the repository at this point in the history