add chevrotain as dependency to VRMLLoader module #16841
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Jun 19, 2019
|
You can remove the following line since it should not be necessary anymore after your change: three.js/examples/webgl_loader_vrml.html Line 25 in c11ee3c |
palortoff
force-pushed
the
add-chevrotain-lib
branch
from
ea3065c to
2e173c5
Compare
|
Done :) |
|
Um, it seems the example does not work anymore: https://raw.githack.com/palortoff/three.js/add-chevrotain-lib/examples/webgl_loader_vrml.html |
|
@palortoff Are you aware that libraries need ES6 builds so they can be imported via ES6 |
Mugen87
changed the title
palortoff
force-pushed
the
add-chevrotain-lib
branch
2 times, most recently
from
1859b8d to
f1d951b
Compare
|
Sorry, I missed that. Now there is an ES6 export. |
Mugen87
reviewed
Jun 20, 2019
palortoff
force-pushed
the
add-chevrotain-lib
branch
from
f1d951b to
049ae1e
Compare
Mugen87
approved these changes
Jun 20, 2019
|
Thanks! |
|
Maybe it's worth putting an issue into the chevrotain repo to provide an es6 module so it doesn't have to be modified manually? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.