Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InterleavedBufferAttribute: Add get / set component functions #27590

Merged
merged 2 commits into from
Jan 19, 2024
Merged

InterleavedBufferAttribute: Add get / set component functions #27590

merged 2 commits into from
Jan 19, 2024

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #24515

Description

Adds getComponent and setComponent functions to the InterleavedBufferAttribute class.

cc @donmccurdy

@gkjohnson gkjohnson added this to the r161 milestone Jan 19, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
671.3 kB (166.8 kB) 671.5 kB (166.9 kB) +238 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
452.3 kB (109.8 kB) 452.3 kB (109.8 kB) +0 B

@gkjohnson gkjohnson mentioned this pull request Jan 19, 2024
Merged
@Mugen87 Mugen87 merged commit 6fe0b84 into mrdoob:dev Jan 19, 2024
12 checks passed
@gkjohnson gkjohnson deleted the interleaved-get-components branch January 20, 2024 01:32
This was referenced Jan 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r161
Development

Successfully merging this pull request may close these issues.
3 participants
@gkjohnson @donmccurdy @Mugen87