Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codesplit WebGL/WebGPU entrypoints: Fix WebGPU Addons #29644

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Oct 14, 2024

Related PR: #29404

Description
Following #29404, fixes webgpu addons resolution with bundlers.
Related comment: #29404 (comment)

Which makes me think that we could even do better by establishing best practices across all WebGPU examples by standardizing proper imports:

<script type="importmap">
	{
		"imports": {
			"three": "../build/three.core.js",
			"three/webgpu": "../build/three.webgpu.js",
			"three/tsl": "../build/three.webgpu.nodes.js",
			"three/addons/": "./jsm/"
		}
	}
</script>

<script type="module">

	import * as THREE from 'three';
	import { WebGPURenderer } from 'three/webgpu'
	import { color, ... } from 'three/tsl';

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r170 milestone Oct 14, 2024
@mrdoob mrdoob modified the milestones: r170, r171 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants