New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPUTextureUtils: Fix usage of `Texture.anisotropy`. #29654

Merged

sunag merged 1 commit into mrdoob:dev from Mugen87:dev2

Oct 14, 2024

Collaborator

Mugen87 commented Oct 14, 2024 •

edited

Loading

Fixed #29653.

Description

GPUSamplerDescriptor.maxAnisotropy can only be set to a value greater than 1 if all filter modes are set to linear.


          WebGPUTextureUtils: Fix usage of Texture.anisotropy.

7bc128d

Mugen87 added this to the r170 milestone

github-actions bot commented Oct 14, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	689.92 170.93	689.92 170.93	+0 B +0 B
WebGPU	814.81 219.39	814.88 219.41	+77 B +22 B
WebGPU Nodes	814.32 219.25	814.39 219.28	+77 B +22 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	462.94 111.81	462.94 111.81	+0 B +0 B
WebGPU	537.62 145.06	537.7 145.08	+77 B +20 B
WebGPU Nodes	493.74 134.79	493.81 134.81	+77 B +18 B

sunag merged commit 26efd87 into mrdoob:dev

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet