-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BatchedMesh: Deprecate old instancing render paths. #29655
base: dev
Are you sure you want to change the base?
BatchedMesh: Deprecate old instancing render paths. #29655
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
I heavily rely on the |
This is an unmaintained code path that does not have a fallback for Firefox. Are you aware your projects will not work there? What about the overdraw lack of sorting is creating? Frankly, I think this is about trying to avoid a migration and not in the interest of the project since nothing is unreachable in practice if you implement |
Description
Deprecates the now-unreferenced instanced multidraw rendering paths from #28103, which was superseded by #28404, and does not implement a fallback for Firefox. Instancing is since emulated by appending instances into the multidraw arguments themselves and using indirection for sorting/visibility, which has a fallback implemented for Firefox.