Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: sRGB decoding for VideoTexture emissiveMap. #29657

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

donmccurdy
Copy link
Collaborator

Implements inline sRGB decoding when a VideoTexture is used as the .emissiveMap for built-in materials.

Related:

Workaround for browser issues:

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.92
170.93
690.29
171.01
+368 B
+78 B
WebGPU 814.88
219.41
814.88
219.41
+0 B
+0 B
WebGPU Nodes 814.39
219.28
814.39
219.28
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.94
111.81
463.31
111.89
+368 B
+76 B
WebGPU 537.7
145.08
537.7
145.08
+0 B
+0 B
WebGPU Nodes 493.81
134.81
493.81
134.81
+0 B
+0 B

@Mugen87 Mugen87 added this to the r170 milestone Oct 15, 2024
@Mugen87 Mugen87 merged commit 752400c into mrdoob:dev Oct 15, 2024
12 checks passed
@Mugen87 Mugen87 changed the title fix(Material): sRGB decoding for VideoTexture .emissiveMap WebGLRenderer: sRGB decoding for VideoTexture emissiveMap. Oct 15, 2024
@donmccurdy donmccurdy deleted the fix/emissivemap-video-srgb branch October 15, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VideoTexture’s colorSpace not working on Emissive channel
2 participants