Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Added double-side transmission 1/2 #29705

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 20, 2024

Related issue: #27880

Description

Adds an individual viewport texture to the back side of the objects. For many refraction objects in the scene with DoubleSide with transmission will need to modify the RenderList this may impact the performance a bit, which is why I am leaving it for another PR.

webgpu_materials_transmission

old now
image image

@sunag sunag added this to the r170 milestone Oct 20, 2024
@sunag sunag changed the title WebGPURenderer: Added double-side transmission WebGPURenderer: Added double-side transmission 1/2 Oct 20, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.71
171.44
692.71
171.44
+0 B
+0 B
WebGPU 818.16
220.56
818.2
220.58
+36 B
+21 B
WebGPU Nodes 817.67
220.43
817.71
220.45
+36 B
+18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.93
112.2
464.93
112.2
+0 B
+0 B
WebGPU 539.13
145.56
539.17
145.6
+36 B
+32 B
WebGPU Nodes 495.16
135.43
495.16
135.43
+0 B
+0 B

@sunag sunag marked this pull request as ready for review October 20, 2024 23:39
@sunag sunag merged commit 39b1f02 into mrdoob:dev Oct 20, 2024
12 checks passed
@sunag sunag deleted the dev-double-viewportTexture branch October 20, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant