New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Make sure default instance of `CompressedTexture` works. #29788

Merged

sunag merged 1 commit into mrdoob:dev from Mugen87:dev2

Nov 2, 2024

Collaborator

Mugen87 commented Nov 1, 2024

Fixed #29785.

Description

The PR makes sure a default instance of CompressedTexture does not throw any runtime errors in WebGPURenderer.


          WebGPURenderer: Make sure default instance of CompressedTexture works.

f5386d4

github-actions bot commented Nov 1, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	692.66 171.56	692.66 171.56	+0 B +0 B
WebGPU	822.12 221.9	822.19 221.92	+73 B +15 B
WebGPU Nodes	821.63 221.78	821.7 221.79	+73 B +13 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.01 112.35	465.01 112.35	+0 B +0 B
WebGPU	542.65 146.78	542.73 146.8	+72 B +15 B
WebGPU Nodes	498.65 136.58	498.72 136.59	+72 B +15 B

Mugen87 added this to the r171 milestone

sunag merged commit 8b0c9ac into mrdoob:dev

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet