Array api #25
Open
Array api #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GIL release for array functions Added check_bytes_within_dist to mirror check_hexstrings_within_dist
Fixed 4 space/8 space tab problems
mrecachinas
requested changes
Mar 2, 2023
There was a problem hiding this comment.
This looks fine. I only noted two changes before we'll want to merge. I'm not certain off-hand why you're observing that benchmark behavior, but I'd have to look further into it.
I'm comfortable merging and cutting a release after you make those changes if it suits your needs. 👍
| @@ -1 +1 @@ | |||
| const char _version[] = "2.2.3"; | |||
| const char _version[] = "2.2.3.1"; | |||
There was a problem hiding this comment.
Since this is adding to the API, let's bump at a minimum the minor version.
Suggested change
| const char _version[] = "2.2.3.1"; | |
| const char _version[] = "2.3.0"; |
| @@ -172,7 +172,7 @@ static PyObject * hamming_distance_byte_wrapper(PyObject *self, PyObject *args) | |||
| * @param args Python arguments for `check_hexstrings_within_dist` interface | |||
| * - `string1` -- hex string | |||
| * - `string2` -- hex string | |||
| * @returns | |||
| * @returns True if the hamming distance is less or equal to max_dist, False otherwise. | |||
There was a problem hiding this comment.
I think the spacing rendered as tabs, so just changing it to spaces here to stay in-line with the other docs.
Suggested change
| * @returns True if the hamming distance is less or equal to max_dist, False otherwise. | |
| * @returns True if the hamming distance is less or equal to max_dist, False otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cleaner APIs for array handling (find first, best, all matches)
Added GIL release for array ops
Added docs for array ops to Readme
Added tests for array ops
Added explicit
hamming_distance_byteto have the same interface ashamming_distance_string. Functionally the find first array op does the same thing, but this being Python I'm weary of having two apparently interchangeable functions that have different return types, that just smells like trouble. ;)It all seems to work fine, as far as I can tell. The only thing I don't understand is the benchmarking: the
bestandallarray ops are about 2 orders of magnitude faster than thefirstone. Either the compiler does very high-level optimization magic, or something is wrong that I can't see...Thanks!