forked from web-platform-tests/wpt
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[anchor] Implement CSSPositionTryDescriptors
CSSPositionTryDescriptors is a CSSStyleDeclaration which restricts which properties are valid, which is a new concept in Blink. This CL implements this by: - Adding a new parsing mode which is stored on the CSSPropertyValueSet within the rule. This ensures that we can't smuggle in invalid properties using cssText. - Filtering properties during setProperty. This ensures that e.g. setProperty('color', ...) doesn't work. Somehow, CSSPositionTryDescriptor is not inheriting the anonymous named getter/setter from the parent, which is actually what we want here. (If this is a bug or something and is changed later, the WPT will fail). The indexed property getter also doesn't seem to work. This is not covered by the tests currently. The problem is tracked by Issue 333965945. Change-Id: I5fa1b600ed50633a9eb9aa8cfeb43726d64ecf90 Bug: 333967631, 333965945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5447110 Reviewed-by: Rune Lillesveen <[email protected]> Reviewed-by: Philip Jägenstedt <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1287213}
- Loading branch information
1 parent
6eb4b61
commit 9fcc5e1
Showing
1 changed file
with
137 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters