Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): make floating window behavior configurable #202

Merged
merged 1 commit into from
May 29, 2024
Merged

feat(api): make floating window behavior configurable #202

merged 1 commit into from
May 29, 2024

Conversation

toupeira
Copy link
Contributor

Implements #201

toupeira
toupeira commented May 26, 2024
View reviewed changes
lua/smart-splits/config.lua Outdated Show resolved Hide resolved
@toupeira toupeira mentioned this pull request May 26, 2024
Closed
1 task
mrjones2014
mrjones2014 requested changes May 27, 2024
View reviewed changes
Copy link
Owner

@mrjones2014 mrjones2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR! Just a couple tiny pieces of feedback and we should be in good shape!

lua/smart-splits/api.lua Outdated Show resolved Hide resolved
lua/smart-splits/api.lua Show resolved Hide resolved
lua/smart-splits/config.lua Outdated Show resolved Hide resolved
@mrjones2014 mrjones2014 changed the title feat: make floating window behavior configurable feat(api): make floating window behavior configurable May 27, 2024
toupeira
toupeira commented May 28, 2024
View reviewed changes
Copy link
Contributor Author

@toupeira toupeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrjones2014 thanks for the review! 🙇

Changes are applied, so this is now ready for another round.

lua/smart-splits/api.lua Outdated Show resolved Hide resolved
lua/smart-splits/config.lua Outdated Show resolved Hide resolved
mrjones2014
mrjones2014 requested changes May 28, 2024
View reviewed changes
Copy link
Owner

@mrjones2014 mrjones2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little thing, just fixing up the type definition, then this is good to merge!

lua/smart-splits/types.lua Show resolved Hide resolved
mrjones2014
mrjones2014 previously approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@mrjones2014 mrjones2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Love it, I'll probably use this option myself.

@toupeira
Copy link
Contributor Author

Oh sorry didn't notice the Stylua errors, fixed now!

@mrjones2014 mrjones2014 merged commit d324074 into mrjones2014:master May 29, 2024
2 checks passed
@toupeira toupeira deleted the feat/float-win-behavior branch May 29, 2024 20:37
@mrjones2014 mrjones2014 mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjones2014 mrjones2014 mrjones2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toupeira @mrjones2014