add platform conversion checks and update unit tests

util/backup_config.go

@@ -70,6 +70,13 @@ func hclDecodeConfig(filePath string) (*BackupConfig, error) {
 		return nil, errors.New("cloud_config block absent")
 	}
 
+	// validate platform
+	platform := backupConfig.CloudConfig.Platform
+	if platform != AWS && platform != GCP {
+		log.Printf("PLATFORM %s is not supported", platform)
+		return nil, errors.New("unsupported platform")
+	}
+
 	return &backupConfig, nil
 }
 
@@ -101,6 +108,10 @@ func envImportConfig() (*BackupConfig, error) {
 		log.Print("CONTAINER and PLATFORM are both required input values, and one or both was unspecified as an environment variable")
 		return nil, errors.New("environment variable absent")
 	}
+	if platform != AWS && platform != GCP {
+		log.Printf("PLATFORM %s is not supported", platform)
+		return nil, errors.New("unsupported platform")
+	}
 
 	return &BackupConfig{
 		CloudConfig: &CloudConfig{

util/backup_config_test.go

@@ -25,7 +25,7 @@ func TestHclDecodeConfig(test *testing.T) {
 	}
 	expectedCloudConfig := CloudConfig{
 		Container: Container,
-		Platform:  "aws",
+		Platform:  AWS,
 		Prefix:    Prefix,
 	}
 
@@ -55,18 +55,18 @@ func TestHclDecodeConfig(test *testing.T) {
 func TestOSImportConfig(test *testing.T) {
 	// source of truth for values
 	const (
-		platform     string = "gcp"
-		addr         string = "https://127.0.0.1:8234"
-		skipVerify   string = "false"
-		authEngine   string = "token"
-		token        string = "abcdefg"
-		awsMount     string = "gcp"
-		awsRole      string = "my_role"
-		snapshotPath string = "/tmp/my_vault.backup"
+		platform     platform = GCP
+		addr         string   = "https://127.0.0.1:8234"
+		skipVerify   string   = "false"
+		authEngine   string   = "token"
+		token        string   = "abcdefg"
+		awsMount     string   = "gcp"
+		awsRole      string   = "my_role"
+		snapshotPath string   = "/tmp/my_vault.backup"
 	)
 
 	os.Setenv("CONTAINER", Container)
-	os.Setenv("PLATFORM", platform)
+	os.Setenv("PLATFORM", string(platform))
 	os.Setenv("PREFIX", Prefix)
 	os.Setenv("VAULT_ADDR", addr)
 	os.Setenv("VAULT_SKIP_VERIFY", skipVerify)
@@ -109,6 +109,11 @@ func TestOSImportConfig(test *testing.T) {
 		test.Errorf("actual snapshot cleanup: %t", config.SnapshotCleanup)
 	}
 
+	os.Setenv("PLATFORM", "foo")
+	if _, err := envImportConfig(); err == nil || err.Error() != "unsupported platform" {
+		test.Errorf("expected error: unsupported platform, actual: %s", err)
+	}
+
 	os.Unsetenv("CONTAINER")
 	if _, err = envImportConfig(); err == nil || err.Error() != "environment variable absent" {
 		test.Errorf("expected error: environment variable absent, actual: %s", err)