Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TERT promoter mutations not able to be tagged through tag_hotspots #236

Open
ionox0 opened this issue Jun 11, 2020 · 1 comment
Open

TERT promoter mutations not able to be tagged through tag_hotspots #236

ionox0 opened this issue Jun 11, 2020 · 1 comment

Comments

@ionox0
Copy link
Member

ionox0 commented Jun 11, 2020

Ronak found that for the TERT promoter mutations that were added to the hotspots list, the hotspot_whitelist column does not get updated because the string "Promoter_1295250" is not a valid HGVSp annotation, and so it doesn't pass a regex for "p.\D+\d+" in the code.

We would like to change the HGVSp_Short for the two TERT mutations in the hotspots list from:

Promoter_1295250
Promoter_1295228

To:

p.0    rs1561215364
p.0    rs1242535815,CA557858711

As p.0 is the suggested annotation for non-coding promoter mutations as designated by the HGVS (https://www.hgvs.org/mutnomen/recs-prot.html - see "changes which affect the promoter of a gene")

In addition to changing this file, the actual fix for the bug would be to remove the aa_pos check from this section of tag_hotspots, and tag all hotspots from the file base on "chr", "position", "ref", and "alt", regardless of whether they have a valid HGVSp annotation.

Change:

aa_pos = re.match( r'^p\.\D+(\d+)', row['HGVSp_Short'])
if aa_pos:
    hotspot[key] = aa_pos.group(1)

To this (make the hotspot variable a set instead of a dictionary):

hotspot.add(tuple(key))

The first two lines prevent us from tagging hotspots that don't have a protein-coding annotation (because "p.0" still would not be a match), and they don't seem to serve any other purpose. But if there's some reason we need to validate the HGVSp with a regex please let me know before I make this change.

@ionox0
Copy link
Member Author

ionox0 commented Jun 11, 2020

@andurill @rhshah @maysunh

@ionox0 ionox0 closed this as completed Jun 11, 2020
@ionox0 ionox0 reopened this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant