-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support case-insensitive search for all views #161
Draft
qu8n
wants to merge
6
commits into
mskcc:dev-ignore-case-searching
Choose a base branch
from
qu8n:requests-case-insensitive-search
base: dev-ignore-case-searching
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support case-insensitive search for all views #161
qu8n
wants to merge
6
commits into
mskcc:dev-ignore-case-searching
from
qu8n:requests-case-insensitive-search
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qu8n
force-pushed
the
requests-case-insensitive-search
branch
from
September 18, 2024 20:57
8ef9ac3
to
fcefb0d
Compare
qu8n
changed the title
Support case-insensitive and partial search for Patients page
Support case-insensitive and partial search for Requests page
Sep 18, 2024
ao508
reviewed
Sep 19, 2024
qu8n
changed the title
Support case-insensitive and partial search for Requests page
Support case-insensitive and partial search
Sep 19, 2024
qu8n
dismissed
ao508’s stale review
September 19, 2024 16:53
Removing this change request as we have discussed over Zoom. The new regex handles partial string matching and eliminates our need for _CONTAINS
.
qu8n
force-pushed
the
requests-case-insensitive-search
branch
from
September 19, 2024 20:40
fcefb0d
to
3847c4c
Compare
qu8n
changed the title
Support case-insensitive and partial search
Support case-insensitive search for all views
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
typeNames
andqueryTerms
outside of the function so that they're only initialized once.*
" in front of the search value so that the it can be matched anywhere inside the string. This removes the need for_CONTAINS
Note that the changes in
yarn.lock
were from the removal of the@neo4j/graphql-ogm
package at the root level.