Feat/#203 support nullable nested objects #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 22, 2022 12:56
… accept 'Object' type re mswjs#203
…using exisiting type AnyObject Change the definition of ModelValueType from 'Object' to 'AnyObject' (an existing type of the library) re 203
when using nullable<MyObject>( ... ), it is impossible to provide an object. It returns 'null' no matter whether an object has been provided or not. re 203
node 'node_modules/.bin/jest' '/Users/aloysberger/FOSS/data/test/model/create.test.ts' -c '/Users/aloysberger/FOSS/data/test/jest.config.ts' -t 'supports nested nullable object' --runInBand re mswjs#203
…bjects Update tests to cover nested nullable objects re mswjs#203
aloysb
commented
May 22, 2022
| return ( | ||
| isPrimitiveValueType(value) || | ||
| Array.isArray(value) || | ||
| typeof value === 'object' |
There was a problem hiding this comment.
Unsure if this is too permissive?
JasonShin
approved these changes
Jun 8, 2022
|
Nice one, can we get it merged? |
|
Hi there! 👋 I've also tried to tackle that one. I think that there may be some parts missing, when for example we'd like to have some default value for nullable object property const db = factory({
user: {
id: primaryKey(faker.datatype.uuid),
address: nullable(() => ({
street: () => "Wall Street",
number: nullable<number>(() => null),
})),
},
});
const user = db.user.create();we may want to have something like {
"id": "...",
"address": {
"street": "Wall Street",
"number": null
}
}for Also, if you run all tests, you may see that there are some issues with types in I created #231 with some investigation I've made some time ago and finished today. Maybe you could take a look there, because you're familiar with the problem and we could figure out some working solution together? |
|
Hi @roertbb, sorry I was quite busy, I'll have a look at your code and get back to you ASAP 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding issue #203
I have extended the existing
ModelValueTypeand the functionisModelValueTypeto allow forobjecttype.I also added a new test case covering the scenario described in #203 .
It was indeed failing at the beginning, the object would be null no matter whether or not you passed to create an existing object.
This was caused by
isModelValueTypethat would returnfalseif the object was not a Primitive or an Array of Primitives.The test is now passing, and I've also tested it manually.
Note that this is my PR for this project and unfortunately the tests were not all green out of the box. So I manually checked where these functions/types were used to ensure I didn't break existing functionalities.
Please don't hesitate to let me know if anything needs to be changed.