fix(fetch): await response listener before resolving the response promise #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
This looks great! Thank you, @mikicho 👏
Yes, it's perfectly fine for the .then() closure to be async. Fetch understands that.
I've adjusted the test names and also added a mock function to assert on the correct order of execution. The tests pass.
kettanaito
changed the title
Released: v0.36.4 🎉This has been released in v0.36.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientRequesttests :)closes #656
@kettanaito Is it OK for the
thencallback to beasync?