Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with reused send buffer #680

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Fix issue with reused send buffer #680

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4ae351
fix: Fix issue with reused send buffer
freehuntx Nov 29, 2024
b87ba6d
Merge branch 'main' into fix-reused-send-buffer
freehuntx Dec 2, 2024
0e47489
fix: Fix typo
freehuntx Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/interceptors/WebSocket/WebSocketOverride.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,14 @@ export class WebSocketOverride extends EventTarget implements WebSocket {
return
}

// We should copy the buffer in case the buffer is reused and changed by the sender
if (ArrayBuffer.isView(data)) {
const buffer = data.buffer.slice(data.byteOffset, data.byteOffset + data.byteLength)
data = Reflect.construct(data.constructor, [buffer])
} else if (data instanceof ArrayBuffer) {
data = data.slice(0)
}

// Buffer the data to send in this even loop
// but send it in the next.
this.bufferedAmount += getDataSize(data)
Expand Down