fix(ClientRequest): prevent rawHeaders from being shared across instances
#694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
reviewed
Jan 2, 2025
| @@ -118,7 +118,7 @@ export function recordRawFetchHeaders() { | |||
| [Reflect.get(headersInit, kRawHeaders)], | |||
| newTarget | |||
| ) | |||
| ensureRawHeadersSymbol(headers, Reflect.get(headersInit, kRawHeaders)) | |||
| ensureRawHeadersSymbol(headers, [...Reflect.get(headersInit, kRawHeaders)]) | |||
There was a problem hiding this comment.
It would be great to add a @note comment here explaining that spreading the headers creates their copy + what issue this prevents.
kettanaito
reviewed
Jan 2, 2025
| @@ -241,3 +241,15 @@ it('does not throw on using Headers before recording', () => { | |||
| request.headers.set('X-My-Header', '1') | |||
| expect(getRawFetchHeaders(request.headers)).toEqual([['X-My-Header', '1']]) | |||
| }) | |||
|
|
|||
| it('does not use the same instance of rawHeaders', async () => { | |||
There was a problem hiding this comment.
rawHeaders inclusion in the name is probably not needed. How about
it('isolates the headers on the instance basis')There was a problem hiding this comment.
I also like linking GitHub issues above the test case names so it's easier to grasp the context for bug fixes.
kettanaito
changed the title
rawHeaders from being shared across instances
kettanaito
approved these changes
Jan 2, 2025
Released: v0.37.4 🎉This has been released in v0.37.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #681