-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new package] crystal 1.15.0 #23200
base: master
Are you sure you want to change the base?
[new package] crystal 1.15.0 #23200
Conversation
Co-authored-by: Biswapriyo Nath <[email protected]>
|
||
prepare() { | ||
# workaround for lack of native symlink support in Git | ||
git clone https://github.com/crystal-lang/crystal.git "$pkgname-$pkgver" -c core.symlinks=true || \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in source array with proper #tag
in the URL. see https://wiki.archlinux.org/title/VCS_package_guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but our repository contains internal, recursive symlinks that seem to break the prepare step, hence the need for this explicit workaround
"${MINGW_PACKAGE_PREFIX}-lld" # needed for linking std_spec | ||
) | ||
source=( | ||
https://github.com/crystal-lang/crystal/releases/download/1.15.0/crystal-1.15.0-windows-x86_64-gnu-unsupported.zip # stage 0 compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/crystal-lang/crystal/releases/download/1.15.0/crystal-1.15.0-windows-x86_64-gnu-unsupported.zip # stage 0 compiler | |
https://github.com/crystal-lang/crystal/releases/download/${pkgver}/crystal-${pkgver}-windows-x86_64-gnu-unsupported.zip # stage 0 compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stage 0 compiler is always 1.15.0, it doesn't change with the MSYS2 package version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But older releases in crystal repository have those compiled tarball also, not the gnu one. Wouldn't future releases have that *-gnu-unsupported.zip ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but if we always use a recent version of the compiler then I believe Crystal itself can be added to makedepends
instead once it is available in MSYS2, so there is never a need to use any version other than 1.15.0 here
Adds the Crystal programming language.
Crystal must be compiled from Crystal itself. An initial 1.15.0 compiler is cross-compiled from Ubuntu using a GitHub workflow; the language's forward compatibility guarantee ensures that this initial compiler should be able to build any subsequent 1.x compiler.
Does not include the Crystal-specific package manager yet.