Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize remove_physics_overrides() a bit #19

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Apr 28, 2024

  • Minor optimization, requires only 1 instead of 3 player:set_physics_override calls.
  • Code is more consistent to the set_physics_overrides function

Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine.

the only minor thing i could nitpick over is that there is now two places for the physics type, so in the future one could get changed, but not the other. could resolve it by having one main table that then is manipulated for set_physics_override if player_moniods isnt present.

but im totally fine with just merging as is

@Niklp09 Niklp09 merged commit 49a878a into master Apr 28, 2024
2 checks passed
@Niklp09 Niklp09 deleted the optimize_rem_phy_ov branch April 28, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants