Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with publishing conditions without state #352

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fixed issue with publishing conditions without state #352

merged 1 commit into from
Oct 20, 2023

Conversation

wsobel
Copy link
Member

@wsobel wsobel commented Oct 19, 2023

  • Added state as a top level key for conditions:

For example:

{"Fault":{"value":"Temperature is too high","dataItemId":"ctmp","nativeCode":"X111","nativeSeverity":"BAD","qualifier":"HIGH","sequence":53,"timestamp":"2018-04-27T05:00:26.555666Z","type":"TEMPERATURE"}}

@wsobel wsobel requested a review from rajwork9 October 19, 2023 23:45
@wsobel wsobel linked an issue Oct 19, 2023 that may be closed by this pull request
2.1.0.6 Docker MQTT Sink - Condition payload does not contain value/type of NORMAL, WARNING, or FAULT #298
Closed
rajwork9
rajwork9 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@rajwork9 rajwork9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, Thank you

@wsobel wsobel merged commit 5199e27 into main Oct 20, 2023
7 checks passed
@wsobel wsobel deleted the fix_mqtt_service_condition_handling branch October 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajwork9 rajwork9 rajwork9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.1.0.6 Docker MQTT Sink - Condition payload does not contain value/type of NORMAL, WARNING, or FAULT
2 participants
@wsobel @rajwork9