Add Better Layer Support #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The export currently adds (attr smd), which marks the footprint as an SMD component (which internally sets the MOD_CMS attribute, and in the GUI marks the component as "Normal+Insert"). This causes it to be exported in a .pos file for a pick & place machine. Since this is just a silkscreen and not an actual component, this makes no sense. This commit instead sets (attr virtual) (which internally sets MOD_VIRTUAL, and in the GUI marks the component as "Virtual") which causes it to be ignored by various parts of kicad that iterate over actual components.
Add notes about python3
The export currently adds (attr smd), which marks the footprint as an SMD component (which internally sets the MOD_CMS attribute, and in the GUI marks the component as "Normal+Insert"). This causes it to be exported in a .pos file for a pick & place machine. Since this is just a silkscreen and not an actual component, this makes no sense. This commit instead sets (attr virtual) (which internally sets MOD_VIRTUAL, and in the GUI marks the component as "Virtual") which causes it to be ignored by various parts of kicad that iterate over actual components.
|
I also added the changes from pull request #14 |
urish
added a commit
to urish/aramcon-badge
that referenced
this pull request
Jan 14, 2019
Includes Python 3 fixes and some of the changes from: mtl/svg2mod#26
urish
added a commit
to aramcon-badge/aramcon-hardware
that referenced
this pull request
Jan 14, 2020
Includes Python 3 fixes and some of the changes from: mtl/svg2mod#26
…an/svg2mod into matthijskooijman-export-as-virtual
…a-master # Conflicts: # README.md
|
This main branch seems dead I'm closing everything out for the new maintained repo https://github.com/svg2mod/svg2mod where this is applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inkscape and Kicad now share a layer name to make it easier to add stuff to the bottom layer (issue #20).
- Removed
--front-onlyflag because it isn't needed with new layer management.- Removed default centering of the image based off of bounding box to make it easier to get precise results.
+ Added
--centerflag so you can still center the modules based on bounding box.+ Added more items to the .gitignore so it is easier to test code