Upgrade to Python 3 and update documentation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2019
herostrat
added a commit
to herostrat/svg2mod
that referenced
this pull request
May 17, 2019
|
@mtl hasn't touched this in years so I think it is dead. If you would like to continue to support this project please checkout the new fork https://github.com/svg2mod/svg2mod. Also if you are interested in joining the svg2mod organization as an active maintainer to prevent it from dying again feel free to open an issue on the new repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently svg2mod only works with Python2 and can only be installed with pip2. However the documentation does not specify which version of Python and the README installation instructions no longer work. This is causing a LOT of confusion as seen in the issue queue: #23 (comment) #24 #28 #29 #34
It seems most new users are assuming this project should work with Python3, which it cannot -- here is a PR that both updates the relevant documentation and installation instructions, as well as code needed to get things working in Python3.
Note: The pip3 installation instructions only work with my branch atm. After merging it will need to be updated from
pip3 install git+https://github.com/zirafa/svg2modtopip3 install git+https://github.com/svg2mod