Update to https://github.com/svg2mod/svg2mod code base #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The export currently adds (attr smd), which marks the footprint as an SMD component (which internally sets the MOD_CMS attribute, and in the GUI marks the component as "Normal+Insert"). This causes it to be exported in a .pos file for a pick & place machine. Since this is just a silkscreen and not an actual component, this makes no sense. This commit instead sets (attr virtual) (which internally sets MOD_VIRTUAL, and in the GUI marks the component as "Virtual") which causes it to be ignored by various parts of kicad that iterate over actual components.
Add notes about python3
The export currently adds (attr smd), which marks the footprint as an SMD component (which internally sets the MOD_CMS attribute, and in the GUI marks the component as "Normal+Insert"). This causes it to be exported in a .pos file for a pick & place machine. Since this is just a silkscreen and not an actual component, this makes no sense. This commit instead sets (attr virtual) (which internally sets MOD_VIRTUAL, and in the GUI marks the component as "Virtual") which causes it to be ignored by various parts of kicad that iterate over actual components.
…an/svg2mod into matthijskooijman-export-as-virtual
…a-master # Conflicts: # README.md
Sodium-Hydrogen
changed the title
Fix many open issues and add new useful features
Better linting and small tweaks to interface
Web application using Streamlit
Fix bug #51 by fixing inlining segment selection. Add basic support for polygons. Allow layer names to also be item names and if an item doesn't have a layer name set it from the id.
Fix bugs and work on non-inkscape support. * Added polygon support. * Fixed arc/ellipse bounding box calculations. * Fixed incorrect inlining point selection. * Support default svg stroke/fill styles. * Refactor confusing variable names. * Allow non-group items to be assigned a layer with `inkscape:label`. * Add fallback for `inkscape:label` to be element id.
svg.text: Pass through glyphSet not method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository has been abandoned for a couple of years. #37
This pull request is an offer to @mtl if he would ever like to take back active maintenance of this super useful tool.
Until such time, all active development will be focused on the fork owned by the svg2mod organization.