Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to pretty (kicad_mod) format as default #9

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

DavidMenting
Copy link
Contributor

@DavidMenting DavidMenting commented Sep 14, 2016

Kasbah's suggestion #8 to set the new kicad_mod (pretty) format as a default output seems to make sense. This one-liner fixes that.

@mtl
Copy link
Owner

mtl commented Nov 18, 2016

Thank you for the pull request.

It makes sense to me too, though I don't know if anyone is depending on the current behavior, which makes me reluctant to introduce the change in the absence of a compelling or urgent need.

I'll leave this open in case someone wants to make a stronger case in support of this change.

@kasbah
Copy link
Contributor

kasbah commented Nov 18, 2016

I think it's a mistake to let backwards compatibility prevent you from making improvements like this.

The changes I suggested in #8 (except for the PyPy one, without PyPy actually seems fine for most things) are only small improvements but they do make the user experience a little bit more pleasant.

I would suggest to improve the interface a bit and then release as a package on PyPI. This would also make it easier to install and prevent issues like #11. Going forward you could then use semantic versioning of the package to ensure that people that rely on the command-line interface can pin their version accordingly.

@DavidMenting
Copy link
Contributor Author

There is no real reason to generate new footprints in the old format any more. Also, you are not removing backward compatibility because the old format is still available. I think it makes sense to make the default output format always track the current one.

If anyone depends on svg2mod generating old KiCad footprints by default, they are unlikely to pull the latest version of svg2mod from GitHub anyway.

@brainstorm
Copy link

+1 for switching to the new format by default, @mtl, please merge this.

@mtl mtl merged commit 1699a90 into mtl:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants