Skip to content

Commit

Permalink
Minor improvements.
Browse files Browse the repository at this point in the history
  • Loading branch information
mtvbrianking committed Feb 1, 2021
1 parent 28e28d2 commit 6708742
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "bmatovu/laravel-artisan-gui",
"description": "Laravel artisan GUI",
"homepage": "https://github.com/mtvbrianking/laravel-artisan-gui",
"type": "project",
"type": "library",
"license": "MIT",
"keywords": [
"laravel",
Expand Down
8 changes: 4 additions & 4 deletions readme.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
![](./images/banner.png)

[![Build Status](https://travis-ci.org/mtvbrianking/laravel-artisan-gui.svg?branch=master)](https://travis-ci.org/mtvbrianking/laravel-artisan-gui)
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/mtvbrianking/laravel-artisan-gui/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/mtvbrianking/laravel-artisan-gui/?branch=master)
[![Tests](https://github.com/mtvbrianking/laravel-route-list/workflows/run-tests/badge.svg)](https://github.com/mtvbrianking/laravel-route-list/actions?query=workflow:run-tests)
[![Documentation](https://github.com/mtvbrianking/laravel-route-list/workflows/gen-docs/badge.svg)](https://mtvbrianking.github.io/laravel-route-list/master)
[![Code Quality](https://scrutinizer-ci.com/g/mtvbrianking/laravel-artisan-gui/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/mtvbrianking/laravel-artisan-gui/?branch=master)
[![Code Coverage](https://scrutinizer-ci.com/g/mtvbrianking/laravel-artisan-gui/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/mtvbrianking/laravel-artisan-gui/?branch=master)
[![StyleCI](https://github.styleci.io/repos/230607368/shield?branch=master)](https://github.styleci.io/repos/230607368)
[![Documentation](https://img.shields.io/badge/Documentation-Blue)](https://mtvbrianking.github.io/laravel-artisan-gui)
[![Code Style](https://github.styleci.io/repos/334360362/shield?branch=master)](https://github.styleci.io/repos/334360362)

## Usage

Expand Down
10 changes: 5 additions & 5 deletions src/Http/CommandController.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,20 @@ class CommandController
*
* @var \Illuminate\Contracts\Validation\Factory
*/
protected $validation;
protected $validationFactory;

/**
* Create a new controller instance.
*
* @param \Illuminate\Contracts\Console\Kernel $kernel
* @param \Illuminate\Contracts\Validation\Factory $validation
* @param \Illuminate\Contracts\Validation\Factory $validationFactory
*
* @return void
*/
public function __construct(Kernel $kernel, ValidationFactory $validation)
public function __construct(Kernel $kernel, ValidationFactory $validationFactory)
{
$this->kernel = $kernel;
$this->validation = $validation;
$this->validationFactory = $validationFactory;
}

/**
Expand Down Expand Up @@ -69,7 +69,7 @@ public function execute(Request $request)
{
$command = $this->resolve($request->command);

$validated = $this->validation->make($request->all(), $this->rules($command))->validate();
$validated = $this->validationFactory->make($request->all(), $this->rules($command))->validate();

$parameters = array_merge($validated, config('artisan-gui.options'));

Expand Down
4 changes: 0 additions & 4 deletions tests/DummyCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ class DummyCommand extends Command
*/
protected $signature = 'command:dummy {arg} {array-args} {--bool-opt} {--value-opt=} {--array-opts=*}';

// protected $signature = 'command:dummy
// {required-arg} {optional-arg?} {default-arg=foo} {array-args*}
// {--bool-option} {--value-option=} {--default-option=bar} {--array-options=*}';

/**
* The console command description.
*
Expand Down

0 comments on commit 6708742

Please sign in to comment.