New library + top folder #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 23, 2024 13:33
degloff
requested changes
Apr 24, 2024
| @@ -11,7 +11,7 @@ | |||
| from phx.fix.model.auth import FixAuthenticationMethod | |||
|
|
|||
| # internal Phoenix FIX example library | |||
| from phx.strategy.random import RandomStrategy | |||
| from src.phx.strategy.random import RandomStrategy | |||
There was a problem hiding this comment.
This is wrong and MUST stay without the source folder reference "src".
You have to read the README.md and do it that way as PyCharm has to know the source folder. That is the only correct way to do it.
Using the project without proper source folder configuration is wrong and conflicts with the "package name" structure of Python: If the package gets installed it will not have the source folder anymore!
There was a problem hiding this comment.
Be probably either
- remove that file alltogether
- move it to the script folder and adjust the path and rename it to run_random.sh
I prefer 1)
There was a problem hiding this comment.
This is correct and should be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a required library eventkit and fixed the top folder for the strategy import statement