forked from MikiDi/mu-python-template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use gunicorn in dev mode #19
Draft
sergiofenoll
wants to merge
7
commits into
mu-semtech:master
Choose a base branch
from
sergiofenoll:feature/use-gunicorn-in-dev-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/use gunicorn in dev mode #19
sergiofenoll
wants to merge
7
commits into
mu-semtech:master
from
sergiofenoll:feature/use-gunicorn-in-dev-mode
Commits on Nov 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ed13f00 - Browse repository at this point
Copy the full SHA ed13f00View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4c28be - Browse repository at this point
Copy the full SHA e4c28beView commit details -
feat: replace gunicorn worker with gthread
The meinheld worker seems to be unmaintained and it doesn't work with gunicorn's reload mechanism.
Configuration menu - View commit details
-
Copy full SHA for 5981fc6 - Browse repository at this point
Copy the full SHA 5981fc6View commit details -
feat: add inotify to requirements
Having inotify installed enables gunicorn's reload mechanism to survive through syntax errors and such in the service code.
Configuration menu - View commit details
-
Copy full SHA for 8f2a1c4 - Browse repository at this point
Copy the full SHA 8f2a1c4View commit details
Commits on Nov 17, 2023
-
feat: don't wrap service code import in a try-except
Using gunicorn's reload mechanism, importing the code in a try-except meant that the reloader would not pick up changes if the initial code import threw an error. The reloader checks which files it needs to listen to notifications for based on its imports. It seems that the combination of a throwing import inside a try block makes it so the reloader doesn't register the service entrypoint as a file it needs to listen to.
Configuration menu - View commit details
-
Copy full SHA for c39c54f - Browse repository at this point
Copy the full SHA c39c54fView commit details -
We no longer use Flask in dev mode, so this if block is never entered.
Configuration menu - View commit details
-
Copy full SHA for 0101e0d - Browse repository at this point
Copy the full SHA 0101e0dView commit details
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3bdbb7b - Browse repository at this point
Copy the full SHA 3bdbb7bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.