Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use gunicorn in dev mode #19

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    ed13f00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4c28be View commit details
    Browse the repository at this point in the history
  3. feat: replace gunicorn worker with gthread

    The meinheld worker seems to be unmaintained and it doesn't work with
    gunicorn's reload mechanism.
    sergiofenoll committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    5981fc6 View commit details
    Browse the repository at this point in the history
  4. feat: add inotify to requirements

    Having inotify installed enables gunicorn's reload mechanism to survive
    through syntax errors and such in the service code.
    sergiofenoll committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    8f2a1c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. feat: don't wrap service code import in a try-except

    Using gunicorn's reload mechanism, importing the code in a try-except
    meant that the reloader would not pick up changes if the initial code
    import threw an error. The reloader checks which files it needs to
    listen to notifications for based on its imports. It seems that the
    combination of a throwing import inside a try block makes it so the
    reloader doesn't register the service entrypoint as a file it needs to
    listen to.
    sergiofenoll committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c39c54f View commit details
    Browse the repository at this point in the history
  2. chore: remove Flask app run

    We no longer use Flask in dev mode, so this if block is never entered.
    sergiofenoll committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0101e0d View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Configuration menu
    Copy the full SHA
    3bdbb7b View commit details
    Browse the repository at this point in the history