Startup the flask dev server the correct way #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in the Flask documentation (https://flask.palletsprojects.com/en/2.3.x/server/#in-code) `app.run` is not the best way to run the flask dev server. It is better to run as `flask run`. This does not crash the server on errors, instead it logs and returns the error and stacktrace.
|
Also appears to be related to #19. However I think this change is smaller, so it might be worth it to merge this one while investigating running with gunicorn |
|
Thank you for the PR and also for referring to the related work of PR19. We have published a build of PR19 which may speed up that work. It may well be that we also want this to be merged in but given the attention the mu-python-template briefly has now, it seems worth to get PR19 tested and merged. We leave this open for the time being because it spun up the work and we might land PR26 (this PR) instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in the Flask documentation (https://flask.palletsprojects.com/en/2.3.x/server/#in-code)
app.runis not the best way to run the flask dev server. It is better to run asflask run. This does not crash the server on errors, instead it logs and returns the error and stacktrace.