Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/viper #28

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Feat/viper #28

merged 9 commits into from
Dec 14, 2023

Conversation

muandane
Copy link
Owner

Fixes #

Proposed Changes

  1. Added Viper for config loading
  2. Cover tests

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (4fe8869) 52.08% compared to head (30cbb78) 47.09%.
Report is 2 commits behind head on main.

❗ Current head 30cbb78 differs from pull request most recent head 9518db0. Consider uploading reports for the commit 9518db0 to get more accurate results

Files Patch % Lines
pkg/config/configInit.go 61.90% 8 Missing ⚠️
pkg/config/config.go 64.28% 4 Missing and 1 partial ⚠️
pkg/utils/askQuestions.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   52.08%   47.09%   -4.99%     
==========================================
  Files           2        3       +1     
  Lines          96      155      +59     
==========================================
+ Hits           50       73      +23     
- Misses         44       73      +29     
- Partials        2        9       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muandane muandane force-pushed the feat/viper branch 2 times, most recently from 59f8169 to d2baa33 Compare December 14, 2023 18:12
@muandane muandane merged commit 4fc45d5 into main Dec 14, 2023
1 check passed
@muandane muandane deleted the feat/viper branch December 14, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant