Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ⚰️: removal of signoff flag in favor of config based value #38

Merged
merged 21 commits into from
Apr 11, 2024

Conversation

muandane
Copy link
Owner

Fixes #

Proposed Changes

  1. add windows binaries and scoop/winget support
  2. removal of signoff flag in favor of config value

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 17.47%. Comparing base (190c66d) to head (1003f35).
Report is 2 commits behind head on main.

❗ Current head 1003f35 differs from pull request most recent head e267127. Consider uploading reports for the commit e267127 to get more accurate results

Files Patch % Lines
pkg/config/git.go 0.00% 15 Missing ⚠️
cmd/root.go 0.00% 8 Missing ⚠️
cmd/man.go 0.00% 7 Missing ⚠️
pkg/config/configInit.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #38       +/-   ##
===========================================
- Coverage   38.94%   17.47%   -21.47%     
===========================================
  Files           4       10        +6     
  Lines         208      412      +204     
===========================================
- Hits           81       72        -9     
- Misses        117      331      +214     
+ Partials       10        9        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muandane muandane force-pushed the feat/win branch 2 times, most recently from ab5fa42 to 0c3c40e Compare March 22, 2024 15:44
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
@muandane
Copy link
Owner Author

LGTM

@muandane muandane merged commit c079f1f into main Apr 11, 2024
1 check failed
@muandane muandane deleted the feat/win branch April 11, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant