Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: commit printing tabs #68

Merged
merged 21 commits into from
Aug 27, 2024
Merged

Fix: commit printing tabs #68

merged 21 commits into from
Aug 27, 2024

Conversation

muandane
Copy link
Owner

@muandane muandane commented Aug 27, 2024

Fixes #

Proposed Changes

  1. remove spinner
  2. simplified man page
  3. simplified questions prompt
  4. simplified root
  5. addressed 🐝 Feature request in non interactive mode, if only the flag -m is provided, it should skip the commit message prompt but still prompt for the type/scope etc... #59 🐝 Feature request: Adding git flags pass through #32

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

muandane added 9 commits July 11, 2024 10:28
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
@muandane muandane changed the title Fix/commitcmd Fix: commit printing tabs Aug 27, 2024
@muandane muandane added the bug Something isn't working label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 38.78788% with 101 lines in your changes missing coverage. Please review.

Project coverage is 38.82%. Comparing base (f6bd0fc) to head (327bba5).
Report is 27 commits behind head on main.

Files Patch % Lines
pkg/utils/askQuestions.go 0.00% 52 Missing ⚠️
cmd/root.go 7.84% 47 Missing ⚠️
cmd/check.go 0.00% 1 Missing ⚠️
pkg/config/git.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #68       +/-   ##
===========================================
+ Coverage   20.75%   38.82%   +18.07%     
===========================================
  Files          10       10               
  Lines         400      358       -42     
===========================================
+ Hits           83      139       +56     
+ Misses        308      210       -98     
  Partials        9        9               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: moualhi zine el abidine <[email protected]>
dd

Signed-off-by: moualhi zine el abidine <[email protected]>

fix 🐛: updated huh code

Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>

fix 🐛: testing dynamic flags

Signed-off-by: moualhi zine el abidine <[email protected]>

fix 🐛: testing dynamic flags

Signed-off-by: moualhi zine el abidine <[email protected]>

fix 🐛: testing dynamic flags

Signed-off-by: moualhi zine el abidine <[email protected]>
@muandane muandane added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code labels Aug 27, 2024
Signed-off-by: moualhi zine el abidine <[email protected]>
Signed-off-by: moualhi zine el abidine <[email protected]>
@muandane muandane merged commit f340614 into main Aug 27, 2024
1 check passed
@muandane muandane deleted the fix/commitcmd branch August 27, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant