Added [email protected] Fixed GifRecorder issues. Fixed #119

Now GifRecorder can record CanvasRenderingContext2D as well.
muaz-khan · Apr 15, 2016 · 1551d95 · 1551d95
1 parent 85613d0
commit 1551d95
Show file tree

Hide file tree

Showing 9 changed files with 31 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -91,7 +91,7 @@ E.g.
 
 ```html
 <!-- use 5.2.6 or any other version -->
-<script src="https://github.com/muaz-khan/RecordRTC/releases/download/5.3.0/RecordRTC.js"></script>
+<script src="https://github.com/muaz-khan/RecordRTC/releases/download/5.3.1/RecordRTC.js"></script>
 ```
 
 There are some other NPM packages regarding RecordRTC:
@@ -734,6 +734,13 @@ The domain www.RecordRTC.org is open-sourced here:
 
 * https://github.com/muaz-khan/RecordRTC/tree/gh-pages
 
+## Issues/Questions?
+
+* Stackoverflow: http://stackoverflow.com/questions/tagged/recordrtc
+* Github: https://github.com/muaz-khan/RecordRTC/issues
+* Disqus: https://www.webrtc-experiment.com/RecordRTC/#ask
+* Email: [email protected]
+
 ## License
 
 [RecordRTC.js](https://github.com/muaz-khan/RecordRTC) is released under [MIT licence](https://www.webrtc-experiment.com/licence/) . Copyright (c) [Muaz Khan](http://www.MuazKhan.com).
diff --git a/RecordRTC.js b/RecordRTC.js
@@ -1,6 +1,6 @@
 'use strict';
 
-// Last time updated: 2016-03-25 12:41:43 PM UTC
+// Last time updated: 2016-04-15 3:06:46 PM UTC
 
 // Open-Sourced: https://github.com/muaz-khan/RecordRTC
 
@@ -1729,6 +1729,9 @@ function MediaStreamRecorder(mediaStream, config) {
         }
 
         if (isMediaStreamActive() === false) {
+            if (!config.disableLogs) {
+                console.log('MediaStream seems stopped.');
+            }
             self.stop();
             return;
         }
@@ -2215,7 +2218,7 @@ function StereoAudioRecorder(mediaStream, config) {
 
         if (isMediaStreamActive() === false) {
             if (!config.disableLogs) {
-                console.error('MediaStream seems stopped.');
+                console.log('MediaStream seems stopped.');
             }
             jsAudioNode.disconnect();
             recording = false;
@@ -3658,9 +3661,9 @@ function GifRecorder(mediaStream, config) {
                 // via: https://github.com/muaz-khan/WebRTC-Experiment/pull/316
                 // Tweak for Android Chrome
                 video.play();
-            }
 
-            context.drawImage(video, 0, 0, canvas.width, canvas.height);
+                context.drawImage(video, 0, 0, canvas.width, canvas.height);
+            }
 
             if (config.onGifPreview) {
                 config.onGifPreview(canvas.toDataURL('image/png'));
@@ -3757,8 +3760,10 @@ function GifRecorder(mediaStream, config) {
     if (isHTMLObject) {
         if (mediaStream instanceof CanvasRenderingContext2D) {
             context = mediaStream;
+            canvas = context.canvas;
         } else if (mediaStream instanceof HTMLCanvasElement) {
             context = mediaStream.getContext('2d');
+            canvas = mediaStream;
         }
     }
 

diff --git a/RecordRTC.min.js b/RecordRTC.min.js
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "recordrtc",
-  "version": "5.3.0",
+  "version": "5.3.1",
   "authors": [
         {
             "name": "Muaz Khan",

diff --git a/dev/GifRecorder.js b/dev/GifRecorder.js
@@ -118,9 +118,9 @@ function GifRecorder(mediaStream, config) {
                 // via: https://github.com/muaz-khan/WebRTC-Experiment/pull/316
                 // Tweak for Android Chrome
                 video.play();
-            }
 
-            context.drawImage(video, 0, 0, canvas.width, canvas.height);
+                context.drawImage(video, 0, 0, canvas.width, canvas.height);
+            }
 
             if (config.onGifPreview) {
                 config.onGifPreview(canvas.toDataURL('image/png'));
@@ -217,8 +217,10 @@ function GifRecorder(mediaStream, config) {
     if (isHTMLObject) {
         if (mediaStream instanceof CanvasRenderingContext2D) {
             context = mediaStream;
+            canvas = context.canvas;
         } else if (mediaStream instanceof HTMLCanvasElement) {
             context = mediaStream.getContext('2d');
+            canvas = mediaStream;
         }
     }
 

diff --git a/dev/MediaStreamRecorder.js b/dev/MediaStreamRecorder.js
@@ -304,6 +304,9 @@ function MediaStreamRecorder(mediaStream, config) {
         }
 
         if (isMediaStreamActive() === false) {
+            if (!config.disableLogs) {
+                console.log('MediaStream seems stopped.');
+            }
             self.stop();
             return;
         }

diff --git a/dev/StereoAudioRecorder.js b/dev/StereoAudioRecorder.js
@@ -476,7 +476,7 @@ function StereoAudioRecorder(mediaStream, config) {
 
         if (isMediaStreamActive() === false) {
             if (!config.disableLogs) {
-                console.error('MediaStream seems stopped.');
+                console.log('MediaStream seems stopped.');
             }
             jsAudioNode.disconnect();
             recording = false;

diff --git a/index.html b/index.html
@@ -924,7 +924,7 @@ <h2 class="header" id="updates" style="color: red; padding-bottom: .1em;"><a hre
             <div id="github-issues"></div>
         </section>
 
-        <section class="experiment">
+        <section id="ask" class="experiment">
             <h2 class="header" id="feedback">Feedback</h2>
             <div>
                 <textarea id="message" style="border: 1px solid rgb(189, 189, 189); height: 8em; margin: .2em; outline: none; resize: vertical; width: 98%;" placeholder="Have any message? Suggestions or something went wrong?"></textarea>

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "recordrtc",
   "preferGlobal": false,
-  "version": "5.3.0",
+  "version": "5.3.1",
   "author": {
     "name": "Muaz Khan",
     "email": "[email protected]",