[EGD-3646] Add starting and switching back apps #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asleszyn
force-pushed
the
asl/EGD-3646/2
branch
from
44ca80b to
9f865b4
Compare
Kejzin
reviewed
Mar 19, 2021
| @@ -120,3 +120,16 @@ def set_tethering_state(self, enabled: bool): | |||
| body = {"tethering": state} | |||
| log.info(f"Set tethering state to: {state}") | |||
| return self.endpoint_request("developerMode", "put", body) | |||
|
|
|||
| def get_application_stack(self): | |||
| body = {"applicationManager": True, "applicationStack": True } | |||
There was a problem hiding this comment.
Won't it be more readable if you put it in two separate lines? I Mean something like that:
body = {"applicationManager": True,
"applicationSTack": True}
lucckb
approved these changes
Mar 19, 2021
SP2FET
reviewed
Mar 22, 2021
|
@SP2FET there is a separate review for the OF part: mudita/MuditaOS#1770 Ideally, this would replace the key combos for app opening (more reliable IMO). |
yep, it should be more reliable but imho it should be discussed - harness had to simulate user's input :) |
SP2FET
approved these changes
Mar 25, 2021
|
Well, we can use both for different kinds of testing. Up to the test design I suppose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.