Classify Terminals & Use Classification #172
Open
+236
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Screen/TMux detection is a bit of an annoyance in this codebase, as evidenced by the fact that this code has been accidentally doing Screen encoding in Copy/CopyPrimary for TMux up until now.
Changes
I figured it would be nice to determine whether the output is tmux or screen up front, and decided to go ahead and consolidate terminal categorization into a single place, using an enum. I fixed Copy/CopyPrimary to only do screen encoding for screen, as well and took the opportunity to move a few other codepoints over to use the enums.