Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android build #108

Merged
merged 1 commit into from
May 11, 2024
Merged

Fix Android build #108

merged 1 commit into from
May 11, 2024

Conversation

muffix
Copy link
Owner

@muffix muffix commented May 11, 2024

Motivation

Fixes a build issue introduced in #83. The package name needs to be updated to match the app's.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Housekeeping (non-code change)

How Has This Been Tested?

  • Jest Unit Test
  • Ran on iOS Simulator
  • Ran on iOS physical device
  • Ran on Android emulator
  • Ran on Android physical device

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Fixes a build issue introduced in #83. The package name needs to be
updated to match the app's.
@muffix muffix enabled auto-merge May 11, 2024 08:35
@muffix muffix disabled auto-merge May 11, 2024 08:35
@muffix muffix merged commit 05e555c into main May 11, 2024
1 check passed
@muffix muffix deleted the fix-build branch May 11, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant