[ScrollArea] Read DirectionProvider and use logical positioning CSS props
#1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
mj12albert
force-pushed
the
fix/scrollarea-dir
branch
from
264ae0b to
4a754f5
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
mj12albert
force-pushed
the
fix/scrollarea-dir
branch
from
4a754f5 to
750577e
Compare
atomiks
approved these changes
Dec 23, 2024
mnajdova
reviewed
Dec 23, 2024
| @@ -35,10 +38,10 @@ const ScrollAreaRoot = React.forwardRef(function ScrollAreaRoot( | |||
|
|
|||
| const contextValue = React.useMemo( | |||
| () => ({ | |||
| dir, | |||
| direction, | |||
There was a problem hiding this comment.
I am curious, what's the benefit of adding the direction in a context, when each subcomponent that need it can read the DirectionProvider's context?
There was a problem hiding this comment.
what's the benefit of adding the direction in a context
It doesn't need to be in the root context anymore, I've updated this ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189
RTL horizontal scroll area demo: https://codesandbox.io/p/sandbox/eloquent-nightingale-s74566