Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip, PreviewCard] Use FloatingPortalLite #1278

Merged
merged 2 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use client';
import * as React from 'react';
import PropTypes from 'prop-types';
import { FloatingPortal } from '@floating-ui/react';
import { usePreviewCardRootContext } from '../root/PreviewCardContext';
import { HTMLElementType, refType } from '../../utils/proptypes';
import { PreviewCardPortalContext } from './PreviewCardPortalContext';
import { FloatingPortalLite } from '../../utils/FloatingPortalLite';

/**
* A portal element that moves the popup to a different part of the DOM.
Expand All @@ -24,7 +24,7 @@ function PreviewCardPortal(props: PreviewCardPortal.Props) {

return (
<PreviewCardPortalContext.Provider value={keepMounted}>
<FloatingPortal root={container}>{children}</FloatingPortal>
<FloatingPortalLite root={container}>{children}</FloatingPortalLite>
</PreviewCardPortalContext.Provider>
);
}
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/tooltip/portal/TooltipPortal.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use client';
import * as React from 'react';
import PropTypes from 'prop-types';
import { FloatingPortal } from '@floating-ui/react';
import { useTooltipRootContext } from '../root/TooltipRootContext';
import { HTMLElementType, refType } from '../../utils/proptypes';
import { TooltipPortalContext } from './TooltipPortalContext';
import { FloatingPortalLite } from '../../utils/FloatingPortalLite';

/**
* A portal element that moves the popup to a different part of the DOM.
Expand All @@ -24,7 +24,7 @@ function TooltipPortal(props: TooltipPortal.Props) {

return (
<TooltipPortalContext.Provider value={keepMounted}>
<FloatingPortal root={container}>{children}</FloatingPortal>
<FloatingPortalLite root={container}>{children}</FloatingPortalLite>
</TooltipPortalContext.Provider>
);
}
Expand Down
20 changes: 20 additions & 0 deletions packages/react/src/utils/FloatingPortalLite.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use client';
import { useFloatingPortalNode } from '@floating-ui/react';
import * as ReactDOM from 'react-dom';

/**
* `FloatingPortal` includes tabbable logic handling for focus management.
* For components that don't need tabbable logic, use `FloatingPortalLite`.
* @ignore - internal component.
*/
export function FloatingPortalLite(props: FloatingPortalLite.Props) {
const node = useFloatingPortalNode({ root: props.root });
return node && ReactDOM.createPortal(props.children, node);
}

namespace FloatingPortalLite {
export interface Props {
children?: React.ReactNode;
root?: HTMLElement | null | React.RefObject<HTMLElement | null>;
}
}
Loading