[Dialog] Don't call onNestedDialogOpen when unmounting a closed nested dialog
#1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
bug 🐛
Netlify deploy preview |
|
After the fix: https://codesandbox.io/p/sandbox/inspiring-meitner-fldgw8?file=%2Fsrc%2FApp.tsx The count seems to be correct now when unmounting/removing a nested dialog whether it was open or closed when removed Just need to add some tests now |
mj12albert
force-pushed
the
fix/nested-dialog-count
branch
from
3660b2e to
f97a877
Compare
mj12albert
force-pushed
the
fix/nested-dialog-count
branch
from
f97a877 to
f3d33cd
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
michaldudak
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279