[Collapsible] Add missing defaults to Collapsible* components #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Netlify deploy preview |
sai6855
added
enhancement
sai6855
commented
Oct 22, 2024
| @@ -22,11 +22,11 @@ const CollapsibleRoot = React.forwardRef(function CollapsibleRoot( | |||
| forwardedRef: React.ForwardedRef<HTMLDivElement>, | |||
| ) { | |||
| const { | |||
| animated, | |||
| animated = true, | |||
There was a problem hiding this comment.
Added deafult props in component,to make it consistent with other components.
github-actions
bot
added
the
PR: out-of-date
|
The default values are set in the hook. We can make it consistent and set everything on the component, though. In this case, I'd recommend making the hook parameters mandatory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing default values of props for Collapsible* components.
Collapsible docs: https://deploy-preview-752--base-ui.netlify.app/components/react-collapsible/