[core] Use hidden prop for keepMounted elements
#815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
commented
Nov 12, 2024
Comment on lines
22
to
24
| if (transitionStatus !== 'entering') { | ||
| setTransitionStatus('entering'); | ||
| } |
There was a problem hiding this comment.
This is necessary after the change, and also seems to fix the CSS Transition Group demo in the popups experiment. Likely should have been the case originally.
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
atomiks
force-pushed
the
popup-keepMounted
branch
from
b11927a
to
14657b6
Compare
github-actions
bot
removed
the
PR: out-of-date
michaldudak
reviewed
Nov 18, 2024
| @@ -9,13 +9,15 @@ import type { | |||
| import { mergeReactProps } from '../../utils/mergeReactProps'; | |||
| import { useAnchorPositioning } from '../../utils/useAnchorPositioning'; | |||
| import type { GenericHTMLProps } from '../../utils/types'; | |||
| import { getInertValue } from '../../utils/getInertValue'; | |||
There was a problem hiding this comment.
Is getInertValue still used anywhere? If not, we can remove it.
| @@ -26,7 +28,7 @@ export function usePopoverPositioner( | |||
| renderedSide, | |||
| renderedAlignment, | |||
| positionerContext, | |||
| } = useAnchorPositioning(params); | |||
| } = useAnchorPositioning({ ...params, mounted }); | |||
There was a problem hiding this comment.
Destructuring the object manually could be faster at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popup animations: https://deploy-preview-815--base-ui.netlify.app/experiments/tooltip
keepMountedby default[data-entering]and wait 1 frame as well, oncehiddengets removed on openinertis no longer necessary for these componentskeepMountedcomponents, both on initial mount and for the lifetime of the mount