[core] Rename CSS vars to include component name #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atomiks
commented
Nov 15, 2024
atomiks
commented
- I have followed (at least) the PR section of the contributing guide.
atomiks
commented
Nov 15, 2024
Comment on lines
+3
to
+4
| max-width: var(--popover-available-width); | ||
| max-height: var(--popover-available-height); |
There was a problem hiding this comment.
If we add component prefixes, this makes classes like this non-reusable across different popups... @vladmoroz. In fact, I'm not sure if this popup is used for popover specifically.
There was a problem hiding this comment.
Hmm yeah good point, I was thinking that the Popup component would be used across different popups, such as Popovers, Preview Cards, Dialogs, etc. Let's discuss it on Monday in detail. We need to consider whether prefixing everything maps well to how components would be styled.
atomiks
commented
Nov 15, 2024
Comment on lines
+191
to
192
| elements.floating.style.setProperty(`--${name}-arrow-origin`, arrowOrigin); | ||
|
|
There was a problem hiding this comment.
The arrow origin and transform origin are a bit different. For edge-aligned popups, you want the transform-origin to be at the edge, not arrow's point/anchor center.
Netlify deploy preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.