[material-ui][Rating] Add component prop
#44199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
new feature
Netlify deploy previewhttps://deploy-preview-44199--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
Oct 24, 2024
|
|
||
| export interface IconContainerProps extends React.HTMLAttributes<HTMLSpanElement> { | ||
| value: number; | ||
| } | ||
|
|
||
| export interface RatingPropsSizeOverrides {} | ||
|
|
||
| export interface RatingProps | ||
| extends StandardProps<React.HTMLAttributes<HTMLSpanElement>, 'children' | 'onChange'> { |
There was a problem hiding this comment.
This felt unnecessary. From my understanding of StandardProps, it seems like StandardProps removes the classes prop and whatever types are passed in the second argument. Even after removing this piece of code, the types of both onChange and children remain unaffected.
Tests in this file seems to confirm same https://github.com/mui/material-ui/pull/44199/files#diff-d2ea835e807d4687379ca84a765aad7416671765d6add33c16ef46bd6bd1499c
mnajdova
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
componentprop toRatingcomponent, check #44181 (comment) for the why