-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Button] Apply correct line height to Button text #44907
Open
kanavbajaj
wants to merge
6
commits into
mui:master
Choose a base branch
from
kanavbajaj:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44907--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
samuelsycamore
changed the title
Fixes #38675. Fix [Button] Text wrap issue.
[Button] Apply correct line height to Button text
Dec 31, 2024
samuelsycamore
added
the
component: button
This is the name of the generic UI component, not the React module!
label
Dec 31, 2024
Hey @kanavbajaj! Thanks for working on this 😊. May I ask you to update/fix the failing tests? You might find our contributing guide useful for this. Assigning @zanivan for review. Victor, may I ask you to check the broken Argos tests? |
DiegoAndai
added
design: material
This is about Material Design, please involve a visual or UX designer in the process
design
This is about UI or UX design, please involve a designer
labels
Jan 9, 2025
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jan 9, 2025
Signed-off-by: Kanav <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jan 9, 2025
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: button
This is the name of the generic UI component, not the React module!
design: material
This is about Material Design, please involve a visual or UX designer in the process
design
This is about UI or UX design, please involve a designer
PR: out-of-date
The pull request has merge conflicts and can't be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38675